Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-24

Make the System Architect the BDFL for Coding Standards

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      Comments

      Description

      This RFC proposes to make the System Architect responsible for the Coding Standards document, rather than the entire TCT committee. If adopted, this RFC will designate the System Architect as the owner of the coding standards document, with the responsibility to decide on acceptance or rejection of changes to coding standards documents.

      Rationale:

      • Coding standards are naturally in the purview of the system architect, as the person responsible for the technical integrity of the system.
      • It's important for coding standards to reflect a coherent set of rules exposing robust and consistent underlying logic. This is best achieved by having one person responsible for them.
      • It removes unnecessary micromanagement and bureaucracy (for example, it's unlikely that the Project Manager or Project Scientist – both members of the TCT – will (or should) track development at this level of detail; therefore, decisions shouldn't be blocked on them).

        Attachments

          Issue Links

            Activity

            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            +1

            Can you clarify which parts of
            https://confluence.lsstcorp.org/display/LDMDG/Standards+and+Policies
            are meant, though? Everything under the "Coding" subhead?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - +1 Can you clarify which parts of https://confluence.lsstcorp.org/display/LDMDG/Standards+and+Policies are meant, though? Everything under the "Coding" subhead?
            Hide
            mjuric Mario Juric added a comment -

            Unless there's objection to this RFC by Wednesday, I move for its adoption.

            Show
            mjuric Mario Juric added a comment - Unless there's objection to this RFC by Wednesday, I move for its adoption.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            ~ +1 I concur that the DM architect should be the ultimate authority for the coding standards. However, I would prefer that changes which will broadly impact work-flow with in DM, including coding standards, are proposed via the RFC mechanism. This would include potential modifications initiated by the DM architect. The team should have a forum for its opinion(s), even if the consensus is non-binding.

            Show
            jhoblitt Joshua Hoblitt added a comment - ~ +1 I concur that the DM architect should be the ultimate authority for the coding standards. However, I would prefer that changes which will broadly impact work-flow with in DM, including coding standards, are proposed via the RFC mechanism. This would include potential modifications initiated by the DM architect. The team should have a forum for its opinion(s), even if the consensus is non-binding.
            Hide
            swinbank John Swinbank added a comment -

            I agree with Joshua Hoblitt but I think that this is already the intention of the RFC – the idea is that the System Architect, rather than the TCT, will have the final word on changes to coding standards which cannot be handled within the regular RFC process, rather than that the Architect explicitly having to rule on every change. On that basis, it sounds fine to me.

            Show
            swinbank John Swinbank added a comment - I agree with Joshua Hoblitt but I think that this is already the intention of the RFC – the idea is that the System Architect, rather than the TCT, will have the final word on changes to coding standards which cannot be handled within the regular RFC process, rather than that the Architect explicitly having to rule on every change. On that basis, it sounds fine to me.
            Hide
            tjenness Tim Jenness added a comment -

            The developer guide was updated by Kian-Tat Lim on Mar 25, 2015.

            Show
            tjenness Tim Jenness added a comment - The developer guide was updated by Kian-Tat Lim on Mar 25, 2015.

              People

              Assignee:
              mjuric Mario Juric
              Reporter:
              mjuric Mario Juric
              Watchers:
              Frossie Economou, Gregory Dubois-Felsmann, Jeff Kantor, John Swinbank, Joshua Hoblitt, Kian-Tat Lim, Mario Juric, Tim Jenness
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  CI Builds

                  No builds found.