Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-245

Add VERBOSE log level (was: Change the default log level from INFO to WARN)

    XMLWordPrintable

Details

    • RFC
    • Status: Implemented
    • Resolution: Done
    • DM
    • None

    Description

      The current default log level is INFO, but I propose that we change it to WARN.

      I.e.

      • WARN Usual level, anything that is printed is interesting every time you see it
      • INFO Extra verbosity if you are feeling nosy or something's odd (i.e. the first layer of added verbosity)
      • DEBUG The sort of thing that you only need if you're willing to wade through a lot of semi-random information
      • TRACE Even more material, but now specific to different sub-systems.

      If you consult https://docs.python.org/2/howto/logging.html, "When to use logging” section you'll note that "The default level is WARNING" and INFO means, "Confirmation that things are working as expected".

      Attachments

        Issue Links

          Activity

            ktl Kian-Tat Lim added a comment -

            It looks like renaming DEBUG to VERBOSE and TRACE to DEBUG will be just as hard if not harder than adding a VERBOSE level. So, much as I would rather discourage adding new custom levels, it looks like the best way to resolve this is to create a new VERBOSE level and move most of the current INFO messages to it.

            In any case, I would say that changing the default level from INFO to WARN is not desirable.

            ktl Kian-Tat Lim added a comment - It looks like renaming DEBUG to VERBOSE and TRACE to DEBUG will be just as hard if not harder than adding a VERBOSE level. So, much as I would rather discourage adding new custom levels, it looks like the best way to resolve this is to create a new VERBOSE level and move most of the current INFO messages to it. In any case, I would say that changing the default level from INFO to WARN is not desirable.
            rowen Russell Owen added a comment -

            +1 to ktl's most recent proposal. I don't know how much work it requires inside the log package but I like it because it is the least disruptive to all code that uses the log package. That will continue to run without change, and we can change the level of existing messages based on time and demand.

            rowen Russell Owen added a comment - +1 to ktl 's most recent proposal. I don't know how much work it requires inside the log package but I like it because it is the least disruptive to all code that uses the log package. That will continue to run without change, and we can change the level of existing messages based on time and demand.
            tjenness Tim Jenness added a comment -

            Adopted as stated in the commentary by ktl: Adding a new VERBOSE logging level between INFO and DEBUG and not changing the default log level from INFO to WARN.

            tjenness Tim Jenness added a comment - Adopted as stated in the commentary by ktl : Adding a new VERBOSE logging level between INFO and DEBUG and not changing the default log level from INFO to WARN.

            It would be useful for the CmdLineActivator in the SuperTask system to allow individuals to set personal defaults for their preferred default logging visibility level.

            gpdf Gregory Dubois-Felsmann added a comment - It would be useful for the CmdLineActivator in the SuperTask system to allow individuals to set personal defaults for their preferred default logging visibility level.
            tjenness Tim Jenness added a comment -

            This is now supported in the lsst.utils.logging.LsstLogAdapter class, which is the logging class now associated with all Tasks. The verbose log level is also understood by pipetask. This was facilitated by the switch away from lsst.log to python logging.

            tjenness Tim Jenness added a comment - This is now supported in the lsst.utils.logging.LsstLogAdapter class, which is the logging class now associated with all Tasks. The verbose log level is also understood by pipetask. This was facilitated by the switch away from lsst.log to python logging.

            People

              ktl Kian-Tat Lim
              rhl Robert Lupton
              Andy Salnikov, Colin Slater, Gregory Dubois-Felsmann, Hsin-Fang Chiang, John Gates, John Parejko, John Swinbank, Kian-Tat Lim, Robert Lupton, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                Jenkins

                  No builds found.