Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-250

API changes in SpatialCellCandidate hierarchy

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      To fix conda build issues on DM-8029, I'm changing the SpatialCellCandidate in the following ways:

      • The getImage method and the _image data member have been removed from SpatialCellImageCandidate, and it is no longer templated. Its only concrete subclass, KernelCandidate, wasn't using the _image method had had to override getImage anyway.
      • SpatialCellMaskedImageCandidate has been removed entirely. Its only concrete subclass, PsfCandidate, now inherits from SpatialCellImageCandidate, since that is now appropriate for MaskedImages and Images.

      This is a backwards incompatible API change, albeit one to an API with very few consumers. It is also an ABI change in afw, and hence will require recompiling all downstream packages.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            This is implemented through DM-8029, right?

            Show
            swinbank John Swinbank added a comment - This is implemented through DM-8029 , right?
            Hide
            jbosch Jim Bosch added a comment -

            Correct, this is on DM-8029. Marking as implemented.

            Show
            jbosch Jim Bosch added a comment - Correct, this is on DM-8029 . Marking as implemented.
            Hide
            jbosch Jim Bosch added a comment -

            Fixed triggering link.

            Show
            jbosch Jim Bosch added a comment - Fixed triggering link.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End: