Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-273

Planned change of arguments for single frame measurement run method

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      When the transition for meas_algorithms to meas_base was originally done, part of Jim's spec was to change the order of arguments in the run() method of SingleFrameMeasurementTask. But since we wanted the meas_algorithms framework to continue to work, we decided to temporarily allow both argument orders,

      As per DM-3804, we are now going to allow only the run(measCat, exposure).

      I intend to track down any contrary instances of this call in the stack, but I may miss things in private code or code outside of the main pipeline. Please inform me of any code which uses the sfm.run(exposure, measCat) ordering so I can fix it during this change.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            +1 I'm strongly in favor of eliminating code that allows mis-ordering of arguments.

            The safest fix is to specify arguments by name.

            Show
            rowen Russell Owen added a comment - - edited +1 I'm strongly in favor of eliminating code that allows mis-ordering of arguments. The safest fix is to specify arguments by name.
            Hide
            yusra Yusra AlSayyad added a comment -

            I remember seeing some in ip_diffim

            Show
            yusra Yusra AlSayyad added a comment - I remember seeing some in ip_diffim
            Hide
            tjenness Tim Jenness added a comment -

            Sounds like everyone is in favor of this and the RFC should be adopted.

            Show
            tjenness Tim Jenness added a comment - Sounds like everyone is in favor of this and the RFC should be adopted.
            Hide
            pgee Perry Gee added a comment -

            All in agreement. Should have been done long ago.

            Show
            pgee Perry Gee added a comment - All in agreement. Should have been done long ago.
            Hide
            tjenness Tim Jenness added a comment -

            Am I correct in thinking this work has been completed? Can you please mark it as Implemented?

            Show
            tjenness Tim Jenness added a comment - Am I correct in thinking this work has been completed? Can you please mark it as Implemented?

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              pgee Perry Gee
              Watchers:
              Jim Bosch, John Swinbank, Perry Gee, Russell Owen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End: