Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
-
Location:The RFC
Description
There is currently a relatively useless calculation of an "effective gain" in the CCD assembly code. This presents a few issues: one is that it adds a piece of metadata that doesn't really add any information (the variance contains this information), and it makes the assembly require a variance plane which may not always make sense depending on when the CCD is assembled.
This is a suggestion to remove this calculation all together. This will require removing the assembleCcd.setGain config parameter.
The suggestion is to remove the setGain method from AssembleCcdTask, remove the setGain config parameter and any mention of it elsewhere.
Attachments
Issue Links
- is triggering
-
DM-4232 Variance is set after dark subtraction
- Done
I talked with Russell about this and he is fine taking it out. I think I may have been the one to actually add it, but it comes in on a commit in 2012 that looks like it may have been the result of migration from svn.
It sounds like we are coming to consensus.