Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-282

Remove effective gain calculation from CCD assembly

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      The RFC

      Description

      There is currently a relatively useless calculation of an "effective gain" in the CCD assembly code. This presents a few issues: one is that it adds a piece of metadata that doesn't really add any information (the variance contains this information), and it makes the assembly require a variance plane which may not always make sense depending on when the CCD is assembled.

      This is a suggestion to remove this calculation all together. This will require removing the assembleCcd.setGain config parameter.

      The suggestion is to remove the setGain method from AssembleCcdTask, remove the setGain config parameter and any mention of it elsewhere.

        Attachments

          Issue Links

            Activity

            Hide
            krughoff Simon Krughoff added a comment -

            I talked with Russell about this and he is fine taking it out. I think I may have been the one to actually add it, but it comes in on a commit in 2012 that looks like it may have been the result of migration from svn.

            It sounds like we are coming to consensus.

            Show
            krughoff Simon Krughoff added a comment - I talked with Russell about this and he is fine taking it out. I think I may have been the one to actually add it, but it comes in on a commit in 2012 that looks like it may have been the result of migration from svn. It sounds like we are coming to consensus.
            Hide
            tjenness Tim Jenness added a comment -

            Simon Krughoff I don't see any disagreement. Please create a triggered work ticket and adopt this RFC.

            Show
            tjenness Tim Jenness added a comment - Simon Krughoff I don't see any disagreement. Please create a triggered work ticket and adopt this RFC.
            Hide
            krughoff Simon Krughoff added a comment -

            The work will be done in DM-4232 unless that's not allowed. This RFC came up in that context initially.

            Show
            krughoff Simon Krughoff added a comment - The work will be done in DM-4232 unless that's not allowed. This RFC came up in that context initially.
            Hide
            tjenness Tim Jenness added a comment -

            Has all the work described in this RFC been implemented?

            Show
            tjenness Tim Jenness added a comment - Has all the work described in this RFC been implemented?
            Hide
            krughoff Simon Krughoff added a comment -

            Oops, yes. I forgot to ship the RFC.

            Show
            krughoff Simon Krughoff added a comment - Oops, yes. I forgot to ship the RFC.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Watchers:
              Merlin Fisher-Levine, Robert Lupton, Simon Krughoff, Tim Jenness
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.