Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-283

Rename coaddTempExp

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      A "coaddTempExp" is an exposure warped to our skymap frame, and originally gained that name because they are temporary products used for creating a coadd.

      The name "coaddTempExp" is arguably obscure and inaccurate. It is obscure because it hasn't been used within astronomy before, and it confuses newcomers. It is inaccurate because they needn't be temporary, and they have uses beyond coaddition. In Pan-STARRS, the same products are termed "warps", have been used for their versions of diffim and multifit, and were commonly requested for download because of their convenience (sharing a common WCS).

      I propose we adopt the name used by Pan-STARRS. The coaddTempExp product would become warp, and makeCoaddTempExp.py would become warpToSkyFrame.py (or similar).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5766 Implement spatial exposure selection task

          • Invalid
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8491 Add Psf-matched CTEs and Coadds as independent data products in DRP

          • Done
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-272 Make PSF-Matched and Non-PSF-Matched CoaddTempExps simultaneously

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-551 Rename MakeCoaddTempExpTask to MakeWarpTask

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            21 older comments
            Hide
            Permalink
            price Paul Price added a comment -

            I don't think we agreed on a task name change following the revision of the dataset name change. I agree it should go on a separate ticket.

            Show
            price Paul Price added a comment - I don't think we agreed on a task name change following the revision of the dataset name change. I agree it should go on a separate ticket.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Paul Price the work triggered by this RFC has been completed. Does this mean the RFC can be marked implemented?

            Show
            tjenness Tim Jenness added a comment - Paul Price the work triggered by this RFC has been completed. Does this mean the RFC can be marked implemented?
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            This was marked as implemented, but DM-4634 was closed as won't fix: I'd like to reopen that to finish this off (as it stands, the warp datasets are produced by the makeCoaddTempExpTask, which is both confusing and an unnecessary mouthful). I think makeWarpTask is a much better alternative, and aligns with the new name of this task.

            Show
            Parejkoj John Parejko added a comment - - edited This was marked as implemented, but DM-4634 was closed as won't fix: I'd like to reopen that to finish this off (as it stands, the warp datasets are produced by the makeCoaddTempExpTask , which is both confusing and an unnecessary mouthful). I think makeWarpTask is a much better alternative, and aligns with the new name of this task.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            DM-4634 is not a triggered ticket for this RFC. If that was a mistake please update the ticket linking.

            Show
            tjenness Tim Jenness added a comment - DM-4634 is not a triggered ticket for this RFC. If that was a mistake please update the ticket linking.
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            The discussion above is a little unclear, but the consensus seems to be that changes to the name of the task should go “on a separate ticket”, which (given the context) I understand to mean on a separate RFC. I therefore don't think that DM-4634 should be regarded as having been triggered by this RFC.

            Show
            swinbank John Swinbank added a comment - - edited The discussion above is a little unclear, but the consensus seems to be that changes to the name of the task should go “on a separate ticket”, which (given the context) I understand to mean on a separate RFC. I therefore don't think that DM-4634 should be regarded as having been triggered by this RFC.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Watchers:
              Colin Slater, Gregory Dubois-Felsmann, Hsin-Fang Chiang, Jim Bosch, John Parejko, John Swinbank, Kian-Tat Lim, Paul Price, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.