Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-290

Remove runIsrTask.py and calibrateTask.py examples from Stack? (for now)

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      This is a suggestion to remove these particular examples (which reside in $IP_ISR_DIR/examples and $PIPE_TASKS_DIR/examples, respectively) from the current Stack distribution, because they don't work in it properly (as documented in DM-9197 and DM-9142), and this amounts to a bit of 'false advertising' to anyone who might try to run them.

      They do work on old tags of the pkgs they are in, and of course long-term we do want working examples for these Tasks, but as all the documentation is currently in transition, and fixing the current examples would take some work which may not be the best use of developers' time currently, it seems the easiest thing to do would be just to remove these.

      (There are other advertised examples that also don't work, but these 2 might be some of the earliest a user may come across, and are the ones I've been most recently testing, so I'm just flagging these up in particular for now.)

      [Also, this is the first time I'm filing an RFC, as suggested to do so for this by John Swinbank, so I hope I have the outlines of this basically right..]

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9520 Remove calibrateTask.py example from Stack (for now)

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9521 Remove runIsrTask.py example from Stack (for now)

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-9142 calibrateTask.py example not working on current stack

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9389 Provide a working IsrTask example

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9390 Provide a working CalibrateTask & CharacterizeImageTask example

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9197 runIsrTask.py example (also) not working on current stack

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            4 older comments
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Has this RFC been adopted? DM-9389 and DM-9390 are the work that we would like to do later but they aren't the work triggered by this RFC.

            Show
            tjenness Tim Jenness added a comment - Has this RFC been adopted? DM-9389 and DM-9390 are the work that we would like to do later but they aren't the work triggered by this RFC.
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Given the RFC expired late on Friday, I'm sure Mandeep Gill [X] will be along to ensure that it's marked as adopted (or otherwise) following the procedure in the Developer Guide sometime shortly.

            Show
            swinbank John Swinbank added a comment - - edited Given the RFC expired late on Friday, I'm sure Mandeep Gill [X] will be along to ensure that it's marked as adopted (or otherwise) following the procedure in the Developer Guide sometime shortly.
            Hide
            Permalink
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited

            As per Dev Guide, marking this issue now as "adopted", as the only comments filed here (and that i had in person with people) were in favor of it, so 2 Jira tikts have been filed to complete the work specified here. (And thx Tim Jenness and John Swinbank for the prompts.)

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited As per Dev Guide, marking this issue now as "adopted", as the only comments filed here (and that i had in person with people) were in favor of it, so 2 Jira tikts have been filed to complete the work specified here. (And thx Tim Jenness and John Swinbank for the prompts.)
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Just for completeness, I'm in favor of this as well. Sorry for not commenting earlier, I thought that I had.

            Show
            krughoff Simon Krughoff added a comment - Just for completeness, I'm in favor of this as well. Sorry for not commenting earlier, I thought that I had.
            Hide
            Permalink
            mssgill Mandeep Gill [X] (Inactive) added a comment -

            NP, thx for the input Simon Krughoff

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - NP, thx for the input Simon Krughoff

              People

              Assignee:
              mssgill Mandeep Gill [X] (Inactive)
              Reporter:
              mssgill Mandeep Gill [X] (Inactive)
              Watchers:
              John Parejko, John Swinbank, Joshua Meyers, Mandeep Gill [X] (Inactive), Paul Price, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.