Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-299

Change IngestCalibsTask to symlink ingested calibration files by default

    Details

    • Type: RFC
    • Status: Withdrawn
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      During the course of DM-5466, which improves the behavior of ingesting decam calibration products from the community pipeline (CP), it became clear that the changes made in obs_decam's IngestCalibs would be well-suited to live in pipe_tasks instead.

      Currently, when ingesting already-existing calibration products (e.g., CP biases and flats), the registry in the calibration repo directory is updated but no files are copied or symlinked. This differs from how regular images are ingested. The default behavior during image ingestion is to symlink image files into a friendly organized-by-date directory structure in the image repo directory.

      Therefore, as part of DM-5466, I propose to make pipe_task's IngestCalibs mirror the file delivery behavior of the image ingestion. The new default behavior of ingesting calibration products will be to symlink (mode=link) these files, instead of the current default which is effectively identical to (mode=skip).

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Sounds good to me.

            Show
            price Paul Price added a comment - Sounds good to me.
            Hide
            tjenness Tim Jenness added a comment -

            Is someone going to reopen this RFC?

            Show
            tjenness Tim Jenness added a comment - Is someone going to reopen this RFC?
            Hide
            ctslater Colin Slater added a comment -

            I think it would be best to leave this one as-is and open a new RFC with the new proposal, since it is rather different.

            Show
            ctslater Colin Slater added a comment - I think it would be best to leave this one as-is and open a new RFC with the new proposal, since it is rather different.
            Hide
            krughoff Simon Krughoff added a comment - - edited

            And I think we can say it's adopted if someone updates the description.
            Changing my mind. Since it changes workflow, I agree with Colin Slater that we should open another RFC.

            Show
            krughoff Simon Krughoff added a comment - - edited And I think we can say it's adopted if someone updates the description. Changing my mind. Since it changes workflow, I agree with Colin Slater that we should open another RFC.
            Hide
            ctslater Colin Slater added a comment -

            Superseded by RFC-341.

            Show
            ctslater Colin Slater added a comment - Superseded by RFC-341 .

              People

              • Assignee:
                mrawls Meredith Rawls
                Reporter:
                mrawls Meredith Rawls
                Watchers:
                Colin Slater, Hsin-Fang Chiang, John Parejko, Meredith Rawls, Nate Pease, Paul Price, Simon Krughoff, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel