Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-300

Add jointcal to lsst_distrib

    XMLWordPrintable

Details

    • RFC
    • Status: Implemented
    • Resolution: Done
    • DM
    • None

    Description

      Now that jointcal has been "beta released", it is ready to be added to lsst_distrib. It passes jenkins on py2 and py3, linux and macOS, and should work on any catalogs processed by a recent version of the stack.

      This RFC is the official request to add jointcal and its dependencies (jointcal_cholmod and testdata_jointcal) to lsst_distrib and/or lsst_apps.

      I think the only question is whether or not to add the testdata_jointcal package to the various exclude files; it's setupOptional in jointcal. Nearly all of jointcal's tests require this package and are skipped if it is not available, but it's 1.4GB when checked out (~700MB of data, doubled from git lfs).

      Attachments

        Issue Links

          Activity

            Please don't add it before the pybind11 merge.

            pschella Pim Schellart [X] (Inactive) added a comment - Please don't add it before the pybind11 merge.
            Parejkoj John Parejko added a comment -

            I wasn't planning on rushing it (RFC end date is next Wednesday), but that's a good point. After the pybind11 merge is completed, I'd need to complete DM-9187, otherwise I assume jointcal would no longer work (it's SWIG currently). I'll add that ticket as a blocker to this.

            Parejkoj John Parejko added a comment - I wasn't planning on rushing it (RFC end date is next Wednesday), but that's a good point. After the pybind11 merge is completed, I'd need to complete DM-9187 , otherwise I assume jointcal would no longer work (it's SWIG currently). I'll add that ticket as a blocker to this.
            Parejkoj John Parejko added a comment -

            Well, pybind11 is now merged, and I have a ticket to make jointcal pybind11-compliant. Any other objections to adding jointcal to lsst_distrib?

            Parejkoj John Parejko added a comment - Well, pybind11 is now merged, and I have a ticket to make jointcal pybind11-compliant. Any other objections to adding jointcal to lsst_distrib?

            I'm all in favour.

            swinbank John Swinbank added a comment - I'm all in favour.
            tjenness Tim Jenness added a comment - - edited

            I am in favor. Please adopt and attach a "is triggering" work ticket. Also, please ensure that jhoblitt sets up the exclusion files for the published builds so that we do not publish the testdata repo.

            tjenness Tim Jenness added a comment - - edited I am in favor. Please adopt and attach a "is triggering" work ticket. Also, please ensure that jhoblitt sets up the exclusion files for the published builds so that we do not publish the testdata repo.
            Parejkoj John Parejko added a comment -

            To be implemented in DM-9752.

            Parejkoj John Parejko added a comment - To be implemented in DM-9752 .
            tjenness Tim Jenness added a comment -

            Parejkoj please close this RFC.

            tjenness Tim Jenness added a comment - Parejkoj please close this RFC.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              John Parejko, John Swinbank, Pim Schellart [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                Jenkins

                  No builds found.