Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-300

Add jointcal to lsst_distrib

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      Now that jointcal has been "beta released", it is ready to be added to lsst_distrib. It passes jenkins on py2 and py3, linux and macOS, and should work on any catalogs processed by a recent version of the stack.

      This RFC is the official request to add jointcal and its dependencies (jointcal_cholmod and testdata_jointcal) to lsst_distrib and/or lsst_apps.

      I think the only question is whether or not to add the testdata_jointcal package to the various exclude files; it's setupOptional in jointcal. Nearly all of jointcal's tests require this package and are skipped if it is not available, but it's 1.4GB when checked out (~700MB of data, doubled from git lfs).

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9187 port jointcal to pybind11

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9752 Add jointcal to lsst_distrib

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Please don't add it before the pybind11 merge.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Please don't add it before the pybind11 merge.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I wasn't planning on rushing it (RFC end date is next Wednesday), but that's a good point. After the pybind11 merge is completed, I'd need to complete DM-9187, otherwise I assume jointcal would no longer work (it's SWIG currently). I'll add that ticket as a blocker to this.

            Show
            Parejkoj John Parejko added a comment - I wasn't planning on rushing it (RFC end date is next Wednesday), but that's a good point. After the pybind11 merge is completed, I'd need to complete DM-9187 , otherwise I assume jointcal would no longer work (it's SWIG currently). I'll add that ticket as a blocker to this.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Well, pybind11 is now merged, and I have a ticket to make jointcal pybind11-compliant. Any other objections to adding jointcal to lsst_distrib?

            Show
            Parejkoj John Parejko added a comment - Well, pybind11 is now merged, and I have a ticket to make jointcal pybind11-compliant. Any other objections to adding jointcal to lsst_distrib?
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I'm all in favour.

            Show
            swinbank John Swinbank added a comment - I'm all in favour.
            Hide
            Permalink
            tjenness Tim Jenness added a comment - - edited

            I am in favor. Please adopt and attach a "is triggering" work ticket. Also, please ensure that Joshua Hoblitt sets up the exclusion files for the published builds so that we do not publish the testdata repo.

            Show
            tjenness Tim Jenness added a comment - - edited I am in favor. Please adopt and attach a "is triggering" work ticket. Also, please ensure that Joshua Hoblitt sets up the exclusion files for the published builds so that we do not publish the testdata repo.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            To be implemented in DM-9752.

            Show
            Parejkoj John Parejko added a comment - To be implemented in DM-9752 .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            John Parejko please close this RFC.

            Show
            tjenness Tim Jenness added a comment - John Parejko please close this RFC.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              John Parejko, John Swinbank, Pim Schellart [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.