Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-320

Add pupil API to cameraGeom.Camera

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      For physical optics PSFs, we require a model of the pupil obscuration, which I propose should be a part of afw.cameraGeom.Camera. In particular, I plan to add abstract base classes

      • cameraGeom.PupilFactory
      • cameraGeom.Pupil

      and make the following API changes:

      • Camera gains a ._pupilFactory attribute and Camera.__init__ gains a pupilFactory kwarg.
      • camera factories makeCameraFromPath and makeCameraFromCatalogs gain a pupilFactory kwarg with default value equal to cameraGeom.PupilFactory
      • CameraMapper gains an attribute pupilFactoryClass with value cameraGeom.pupilFactory. Subclasses (e.g., HscMapper) can then set this attribute to a camera-specific pupilFactory as desired.
      • CameraMapper._makeCamera passes self.pupilFactoryClass to makeCameraFromPath

      See CLO post here for more details. Also, since some discussion already exists on the CLO post, please add additional comments there.

        Attachments

          Issue Links

            Activity

            Hide
            jmeyers314 Joshua Meyers added a comment -

            A bit out-of-order, but I'm going to claim this RFC is triggering DM-9572.

            Show
            jmeyers314 Joshua Meyers added a comment - A bit out-of-order, but I'm going to claim this RFC is triggering DM-9572 .

              People

              • Assignee:
                jmeyers314 Joshua Meyers
                Reporter:
                jmeyers314 Joshua Meyers
                Watchers:
                John Swinbank, Joshua Meyers, Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel