Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-350

Clarify in DPDD that filterName will be included with DIASources

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:

      Description

      The DIASource record given in the DPDD (in Table 1) does not contain the filterName that the source is detected in; it is stored in the CcdVisit table because of database normalization. Accordingly, the DPDD does not explicitly specify that the alert packet will identify which filter a DIASource was detected in (Section 4.5.1).

      Since we must know the filter in order to interpret the flux measurements in an alert packet, I propose we clarify that filterName will be included with each DIASource in the alerts.

      Based on previous discussion in DM-8050, I believe the filterName is already included as a foreign key in the DIASource cat schema, so this change only requires a documentation change.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Rather than phrasing this as adding filterName to DIASource, could we make a list of fields from the CcdVisit table that will also be included in alerts?

            Show
            jbosch Jim Bosch added a comment - Rather than phrasing this as adding filterName to DIASource, could we make a list of fields from the CcdVisit table that will also be included in alerts?
            Hide
            ebellm Eric Bellm added a comment -

            It's not obvious to me that there are others that need to be included from CcdVisit.

            From Visit, one might imagine including programID to enable downstream filtering (e.g., broker selection of Deep Drilling observations), but I tend to think that can be accomplished as easily with spatial cuts. In general users will want all the data available (regardless of what program triggered it), in any case.

            Show
            ebellm Eric Bellm added a comment - It's not obvious to me that there are others that need to be included from CcdVisit. From Visit, one might imagine including programID to enable downstream filtering (e.g., broker selection of Deep Drilling observations), but I tend to think that can be accomplished as easily with spatial cuts. In general users will want all the data available (regardless of what program triggered it), in any case.
            Hide
            tjenness Tim Jenness added a comment -

            Eric Bellm please add the triggered implementation ticket to this RFC.

            Show
            tjenness Tim Jenness added a comment - Eric Bellm please add the triggered implementation ticket to this RFC.
            Hide
            ebellm Eric Bellm added a comment -

            Accepted; implementation ticket is DM-11247.

            Show
            ebellm Eric Bellm added a comment - Accepted; implementation ticket is DM-11247 .
            Hide
            tjenness Tim Jenness added a comment -

            Eric Bellm it looks like this RFC can be marked as implemented.

            Show
            tjenness Tim Jenness added a comment - Eric Bellm it looks like this RFC can be marked as implemented.

              People

              Assignee:
              ebellm Eric Bellm
              Reporter:
              ebellm Eric Bellm
              Watchers:
              Eric Bellm, Jim Bosch, Leanne Guy, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins Builds

                  No builds found.