Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      The class BinnedWcs is defined in meas_algorithms, but is not used anywhere. The class has no doc string so I'm not sure what it was intended for. It inherits from afw::image::Wcs but does not implement some of its methods and is not persistable.

      I would like to get rid of it as part of the Wcs->SkyWcs change. If we ever do want to construct a binned WCS from an afw::geom::SkyWcs it would be simpler to construct a SkyWcs that adds a binning transform internally, thus producing a normal Wcs, thus offering persistence and all other SkyWcs methods, but no memory of the unbinned Wcs.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue is triggering DM-10765 [ DM-10765 ]
            Hide
            jbosch Jim Bosch added a comment -

            Doing a git blame and looking up the ticket associated with the merge responsible for most of the commits might solve the mystery.

            Show
            jbosch Jim Bosch added a comment - Doing a git blame and looking up the ticket associated with the merge responsible for most of the commits might solve the mystery.
            Hide
            price Paul Price added a comment -

            As the original author of BinnedWcs, I approve.

            Show
            price Paul Price added a comment - As the original author of BinnedWcs , I approve.
            Hide
            rowen Russell Owen added a comment -

            Adopted as stated

            Show
            rowen Russell Owen added a comment - Adopted as stated
            rowen Russell Owen made changes -
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            rowen Russell Owen made changes -
            Summary I would like to delete BinnedWcs Delete BinnedWcs
            Hide
            tjenness Tim Jenness added a comment -

            Russell Owen is this RFC now implemented?

            Show
            tjenness Tim Jenness added a comment - Russell Owen is this RFC now implemented?
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Adopted [ 10806 ] Implemented [ 11105 ]

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Watchers:
                Jim Bosch, John Swinbank, Paul Price, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel