Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-431

Adding new third party package to sims stack

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: Sims
    • Labels:
      None

      Description

      I would like to update the version of the third party package SNCosmo in the simulations stack. Meanwhile, SNcosmo functionality has been split and some of it is moved into a cython package extinction. This is now a dependency for the usual SNCosmo package. So, including this will be useful for upgrading SNCosmo. 

      Within the simulations stack, our functions replace the extinction calculations with `sims_photUtils` based extinction calculations. We will continue to use these, so no calculations will change on account of adding `extinction`. It will allow users to use the LSST simulations stack sncosmo and also simultaneously continue doing other sncosmo functions (like certain fitting functions) which simulations stack does not offer.

       

      In terms of DM functionality, the effects are quite minor: this would occupy a spot in the lsst github repository and perhaps make it difficult for a future package with the same name. Additionally, it could need to be tested on Jenkins.  

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Can you please create a ticket for adding the package? Otherwise I can't tell when the RFC is implemented. Thank you.

            Show
            tjenness Tim Jenness added a comment - Can you please create a ticket for adding the package? Otherwise I can't tell when the RFC is implemented. Thank you.
            Hide
            danielsf Scott Daniel added a comment -

            SIM-2593 represents the actual work adding this package to the stack.

            Show
            danielsf Scott Daniel added a comment - SIM-2593 represents the actual work adding this package to the stack.
            Hide
            tjenness Tim Jenness added a comment -

            Thanks. I've added the link.

            Show
            tjenness Tim Jenness added a comment - Thanks. I've added the link.
            Hide
            tjenness Tim Jenness added a comment -

            Can we mark this RFC as implemented? The triggered SIMs ticket has been closed? cc Lynne Jones

            Show
            tjenness Tim Jenness added a comment - Can we mark this RFC as implemented? The triggered SIMs ticket has been closed? cc Lynne Jones
            Hide
            ljones Lynne Jones added a comment -

            Yes, sorry. This RFC should have been closed when the work was completed. 

            Show
            ljones Lynne Jones added a comment - Yes, sorry. This RFC should have been closed when the work was completed. 

              People

              Assignee:
              rbiswas Rahul Biswas
              Reporter:
              rbiswas Rahul Biswas
              Watchers:
              Lynne Jones, Rahul Biswas, Scott Daniel, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.