Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-433

Update LoadAstrometryNetObjectsTask to use config instead of env variables

    Details

    • Type: RFC
    • Status: Withdrawn
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      The dataset name and data directory for LoadAstrometryNetObjectsTask are defined via environment variables, whereas for LoadIndexedReferenceObjectsTask they are configurables. Thus, there is no common api for identifying the dataset name for Colorterms, and switching between the catalog types may require setting those environment variables.

      If we want to keep A.Net refcats viable, we need to at least somewhat modernize the Task and keep the APIs consistent. This RFC proposes to remove the SETUP_ASTROMETRY_NET_DATA and ASTROMETRY_NET_DATA_DIR env vars and replace them with Config parameters, including a ref_dataset_name in the base class, to match LoadIndexedReferenceObjectsTask.

      An alternate option for this RFC would be to write an a.net->Indexed refcat converter, and remove LoadAstrometryNetObjectsTask.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Watchers:
                Colin Slater, Jim Bosch, John Parejko, John Swinbank, Kian-Tat Lim, Lauren MacArthur, Paul Price, Simon Krughoff
              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel