Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-437

Drop GaussianCentroid

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      GaussianCentroid is a measurement algorithm in meas_base that fits a 2D Gaussian to sources to determine the centroid. We have recently discovered that the code has bugs (DM-13299).

      I propose dropping GaussianCentroid, which will save on maintenance effort. Since SdssCentroid performs at least as well, is faster, and (as far as I am aware) is always preferred by developers and users, I believe the only reason not to drop GaussianCentroid is to keep a second centroiding algorithm in the main stack. I suggest that if we find that we need a second centroiding algorithm in the future, the code could be resurrected from git.

        Attachments

          Issue Links

            Activity

            price Paul Price created issue -
            price Paul Price made changes -
            Field Original Value New Value
            Attachment dma6.jpg [ 31772 ]
            price Paul Price made changes -
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            price Paul Price made changes -
            Link This issue is triggering DM-13395 [ DM-13395 ]
            price Paul Price made changes -
            Resolution Done [ 10000 ]
            Status Adopted [ 10806 ] Implemented [ 11105 ]

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Watchers:
              David Monet, John Parejko, John Swinbank, Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.