Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-462

Temporarily include meas_mosaic in lsst_distrib

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      Members of the commissioning team would like to be able to use meas_mosaic whilst they are waiting for jointcal to be released. Robert Lupton and Jeffrey Carlin suggested that the easiest approach is to temporarily include meas_mosaic in lsst_distrib so that it appears in the weeklies.  An additional Jira issue should be opened in order not to forget to remove meas_mosaic once jointcal is released.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Is lsst.obs.hsc what you get from obs_subaru then? I didn't spot that subtlety.

            I was imprecise (and obs_subaru is weird): the obs_subaru package includes the lsst.obs.subaru, lsst.obs.hsc, and lsst.obs.suprimecam Python packages.

            Show
            jbosch Jim Bosch added a comment - Is  lsst.obs.hsc  what you get from  obs_subaru  then? I didn't spot that subtlety. I was imprecise (and obs_subaru is weird): the obs_subaru package includes the lsst.obs.subaru , lsst.obs.hsc , and lsst.obs.suprimecam Python packages.
            Hide
            tjenness Tim Jenness added a comment -

            Can we add setupOptional(obs_subaru) to the table file?

            Show
            tjenness Tim Jenness added a comment - Can we add setupOptional(obs_subaru) to the table file?
            Hide
            jbosch Jim Bosch added a comment -

            Can we add setupOptional(obs_subaru) to the table file?

            That makes sense to me, as long as it doesn't actually confuse EUPS to have a circular dependency involving optionals.

            Show
            jbosch Jim Bosch added a comment - Can we add  setupOptional(obs_subaru)  to the table file? That makes sense to me, as long as it doesn't actually confuse EUPS to have a circular dependency involving optionals.
            Hide
            tjenness Tim Jenness added a comment -

            This:

            diff --git a/ups/meas_mosaic.table b/ups/meas_mosaic.table
            index 9fe1e81..02fcb61 100644
            --- a/ups/meas_mosaic.table
            +++ b/ups/meas_mosaic.table
            @@ -14,6 +14,7 @@ setupRequired(meas_astrom)
             setupRequired(meas_base)
             setupRequired(meas_algorithms)
             setupRequired(minuit2)
            +setupOptional(obs_subaru)
             
             envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
             envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
            

            works fine in my local tests and does allow the both tests to run and pass. I think it would make me feel better including it in lsst_distrib if both the tests ran.

            Show
            tjenness Tim Jenness added a comment - This: diff --git a/ups/meas_mosaic.table b/ups/meas_mosaic.table index 9fe1e81..02fcb61 100644 --- a/ups/meas_mosaic.table +++ b/ups/meas_mosaic.table @@ -14,6 +14,7 @@ setupRequired(meas_astrom) setupRequired(meas_base) setupRequired(meas_algorithms) setupRequired(minuit2) +setupOptional(obs_subaru) envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) works fine in my local tests and does allow the both tests to run and pass. I think it would make me feel better including it in lsst_distrib if both the tests ran.
            Hide
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

            RFC is adopted, however, just to be clear, meas_mosaic will not be part of 15.0 releases.

            It will be removed as soon as jointcal is ready to be used.

            In the meantime, science pipelines group are responsible for looking into breaking changes related to meas_mosaic.

            Show
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - RFC is adopted, however, just to be clear, meas_mosaic will not be part of 15.0 releases. It will be removed as soon as jointcal is ready to be used. In the meantime, science pipelines group are responsible for looking into breaking changes related to meas_mosaic.

              People

              Assignee:
              gcomoretto Gabriele Comoretto [X] (Inactive)
              Reporter:
              gcomoretto Gabriele Comoretto [X] (Inactive)
              Watchers:
              Frossie Economou, Gabriele Comoretto [X] (Inactive), Hsin-Fang Chiang, Jeffrey Carlin, Jim Bosch, John Parejko, John Swinbank, Kian-Tat Lim, Paul Price, Robert Lupton, Tim Jenness
              Votes:
              1 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.