Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-464

Remove untested database code from obs_sdss and obs_lsstSim

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      In discussing implementation of RFC-449, it was noticed that obs_lsstSim and obs_sdss both import mysqlclient in python. The only reason for this is to support a class which can select images from a database based on a query. If we can remove the dependency on the python_mysqlclient package, the need for GnuTLS as a dependency on MacOS will go away, meaning we will not need to change the install process in any way as the DM stack dependence on mariadb will disappear.

      I believe it is a reasonable request for several reasons:
      1. This code is not used in any active pipelines, as far as I know.
      2. That code path is not tested under CI since the test is disabled if there is no database connection which is the case for all VMs running inside Jenkins.
      3. The mechanism for doing just this sort of data discovery is changing when the Gen3 data abstraction system lands (in the next few months).

      Classes to be removed are here, here, here and here.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Watchers:
              John Parejko, John Swinbank, Kian-Tat Lim, Russell Owen, Simon Krughoff, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.