Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
-
Location:This ticket, or the Data Management chat room
Description
As part of DM-2635 I propose to make the following changes to the C++ API of the "utils" package:
Remove two functions we are not using anywhere:
- guessSvnVersion: this is clearly useless now that we use git
- stringToAny: we aren't using it, and it has no documentation
Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful. This would be the implementation of DM-2635.
Attachments
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Description |
As part of Remove two functions we are not using anywhere: - guessSvnVersion: this is clearly useless now that we use git - stringToAny: we aren't using it, and it has no documentation Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful. |
As part of Remove two functions we are not using anywhere: - guessSvnVersion: this is clearly useless now that we use git - stringToAny: we aren't using it, and it has no documentation Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful. This would be the implementation of |
Resolution | Done [ 10000 ] | |
Status | Proposed [ 10805 ] | Adopted [ 10806 ] |
Status | Adopted [ 10806 ] | Implemented [ 11105 ] |
Here is a relevant bit from the Data Management HipChat room 2015-04-28
[4:23 PM] Russell Owen: I'm looking through the C++ functions provided by utils and I've found two that don't seem to be used anywhere: guessSvnVersion (no surprise) and stringToAny. The latter is not even documented, though it's easy to see what it does by reading its code. Can I remove these as part of
DM-2635?[4:26 PM] K-T Lim: Looks like the latter was expected to be used in FITS-reading code. OK with me to remove both.
(Should really have a quick RFC to make sure everyone knows, but since there are no references, I don't see how this could hurt, and it's easy to put back.)
[4:27 PM] Robert Lupton: As @ktl wrote stringToAny and it doesn't show up in anything I have checked out, it's good to delete. But in general we need a way to remove APIs