Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-47

Remove unused utils functions and change eups::productDir to getPackageDir

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      This ticket, or the Data Management chat room

      Description

      As part of DM-2635 I propose to make the following changes to the C++ API of the "utils" package:

      Remove two functions we are not using anywhere:

      • guessSvnVersion: this is clearly useless now that we use git
      • stringToAny: we aren't using it, and it has no documentation

      Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful. This would be the implementation of DM-2635.

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-2635 Provide a function to return the path to a package, given its name

          • Done
          is triggering

          Improvement - An improvement or enhancement to an existing feature or task. DM-4385 Remove stringToAny from the utils package

          • Done

            Activity

            Ascending order - Click to sort in descending order
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Description As part of DM-2635 I propose to make the following changes to the C++ API of the "utils" package:

            Remove two functions we are not using anywhere:
            - guessSvnVersion: this is clearly useless now that we use git
            - stringToAny: we aren't using it, and it has no documentation

            Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful.
            		 As part of DM-2635 I propose to make the following changes to the C++ API of the "utils" package:

            Remove two functions we are not using anywhere:
            - guessSvnVersion: this is clearly useless now that we use git
            - stringToAny: we aren't using it, and it has no documentation

            Rename lsst::utils::eups::productDir to lsst::utils::getPackageDir and remove the version argument. Note that the version argument has only one valid value, so it's never been useful. This would be the implementation of DM-2635.
            rowen Russell Owen made changes -
            Link This issue blocks DM-2635 [ DM-2635 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            rowen Russell Owen made changes -
            Link This issue is triggering DM-4385 [ DM-4385 ]
            rowen Russell Owen made changes -
            Status Adopted [ 10806 ] Implemented [ 11105 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Watchers:
              Kian-Tat Lim, Mario Juric, Robert Lupton, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.