Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-512

Remove --small option from the stack demo

    Details

    • Type: RFC
    • Status: Adopted
    • Resolution: Unresolved
    • Component/s: DM
    • Labels:
      None

      Description

      Currently the SDSS demo contained in lsst_dm_stack_demo has two options: --small and by extension large. It turns out that difference between the two is whether there are five bands run on two visits or three bands on two visits. I.e. six sensors vs. ten sensors. This difference is very minimal in the context of an integration test.

      If we remove the demo.sh afterburner and instead run the demo as part of lsst_ci via scons, as is the plan, I would prefer that the default be the full run. If we change the test to use the full run, as opposed to the --small version, the --small flag will no longer be tested anywhere (the non-small version was implicitly being tested by running the demo with stack_os_matrix).

      In order to simplify the demo, I would like to remove the --small option completely and have only one way to run the demo.

      The work would be minimal. The only places the --small switch are mentioned in the lsst org are in the demo package itself and in the pipelines docs. There are several places the jenkins pipelines offer the option to run the demo using the --small option, but I believe the SQuaRE team could easily update those.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            +1 Sounds like a good change.

            Show
            Parejkoj John Parejko added a comment - +1 Sounds like a good change.
            Hide
            tjenness Tim Jenness added a comment -

            Sounds like no-one is going to object to this.

            Show
            tjenness Tim Jenness added a comment - Sounds like no-one is going to object to this.
            Hide
            krughoff Simon Krughoff added a comment -

            I'm going to make this as adopted.

            Show
            krughoff Simon Krughoff added a comment - I'm going to make this as adopted.
            Hide
            krughoff Simon Krughoff added a comment -

            DM-15550 is the implementation ticket for this.

            Show
            krughoff Simon Krughoff added a comment - DM-15550 is the implementation ticket for this.

              People

              • Assignee:
                krughoff Simon Krughoff
                Reporter:
                krughoff Simon Krughoff
                Watchers:
                John Parejko, John Swinbank, Simon Krughoff, Tim Jenness
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Planned End:

                  Summary Panel