Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-545

Deprecate ScaleZeroPointTask

    Details

    • Type: RFC
    • Status: Adopted
    • Resolution: Unresolved
    • Component/s: DM
    • Labels:
      None

      Description

      assembleCoadd.py performs a step where it scales the input images to a "common zero point" using ScaleZeroPointTask. DM-15254 implemented PhotoCalib.calibrateImage() which photometrically calibrates images directly. DM-15751 uses the new calibrateImage method to return those calibrated images during coaddition, removing the need for ScaleZeroPointTask.

      Note that this is not really a change in what "units" coaddition is working in: after scaleZeroPoint.run(), the images should be in a physical flux unit, divided by some common scale factor. This RFC just proposes to remove that common scale factor and have the makeCoaddTempExp output all have a photometric calibration of 1.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            John Parejko what do you want to do with this RFC?

            Show
            tjenness Tim Jenness added a comment - John Parejko what do you want to do with this RFC?
            Hide
            Parejkoj John Parejko added a comment -

            There seems to be agreement above that we could disable but not remove ScaleZeroPoint after PhotoCalib is modified to work in nanoJansky and then replaces Calib. Do others agree that is a reasonable compromise?

            Show
            Parejkoj John Parejko added a comment - There seems to be agreement above that we could disable but not remove ScaleZeroPoint after PhotoCalib is modified to work in nanoJansky and then replaces Calib . Do others agree that is a reasonable compromise?
            Hide
            ktl Kian-Tat Lim added a comment -

            Sounds like the last proposal is workable. Can we adopt and add a (blocked) implementation ticket?

            Show
            ktl Kian-Tat Lim added a comment - Sounds like the last proposal is workable. Can we adopt and add a (blocked) implementation ticket?
            Hide
            ktl Kian-Tat Lim added a comment -

            John Parejko: Can we move forward here?

            Show
            ktl Kian-Tat Lim added a comment - John Parejko : Can we move forward here?
            Hide
            Parejkoj John Parejko added a comment -

            Adopting with DM-17018, which deprecates and allows us to disable ScaleZeroPointTask, once PhotoCalib replaces Calib. We can use the results of disabling this scaling while making warps and coadds to decide whether to further remove it.

            Show
            Parejkoj John Parejko added a comment - Adopting with DM-17018 , which deprecates and allows us to disable ScaleZeroPointTask, once PhotoCalib replaces Calib. We can use the results of disabling this scaling while making warps and coadds to decide whether to further remove it.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Watchers:
                Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls, Paul Price, Tim Jenness, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Planned End:

                  Summary Panel