Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-560

Remove CatalogStarSelectorTask

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      Per DM-9837, CatalogStarSelector does not appear to be used anywhere in the stack currently. It therefore makes sense to delete this piece of code from the stack.  This will prevent having to update the Doxegyn to Sphinx/numpydoc as per. DM-14133

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            We will someday need some kind of catalog-based star selector, but I don't think the API for this one has ever made sense, and that is reflected in its lack of use.  Essentially, a catalog-based star selector can't really have a proper is-a relationship with a base class that has no way to provide such a catalog in its interface.

            Show
            jbosch Jim Bosch added a comment - We will someday need some kind of catalog-based star selector, but I don't think the API for this one has ever made sense, and that is reflected in its lack of use.  Essentially, a catalog-based star selector can't really have a proper is-a relationship with a base class that has no way to provide such a catalog in its interface.
            Hide
            tjenness Tim Jenness added a comment -

            Chris Morrison what do you want to do with this RFC? I suggest we adopt it based on the comment from Jim Bosch.

            Show
            tjenness Tim Jenness added a comment - Chris Morrison what do you want to do with this RFC? I suggest we adopt it based on the comment from Jim Bosch .
            Hide
            cmorrison Chris Morrison added a comment -

            Hey Tim,

            Thanks for reminding me. I agree and will mark this as Adopted and make a ticket to delete the task.

            Show
            cmorrison Chris Morrison added a comment - Hey Tim, Thanks for reminding me. I agree and will mark this as Adopted and make a ticket to delete the task.
            Hide
            cmorrison Chris Morrison added a comment -

            Adopting RFC-560 removing the unused CatalogStarSelector.

            Show
            cmorrison Chris Morrison added a comment - Adopting RFC-560 removing the unused CatalogStarSelector.
            Hide
            tjenness Tim Jenness added a comment -

            Chris Morrison it looks like this RFC can be marked as implemented.

            Show
            tjenness Tim Jenness added a comment - Chris Morrison it looks like this RFC can be marked as implemented.
            Hide
            cmorrison Chris Morrison added a comment -

            Hey Tim, is that state the "We Shipped It!" button?

            Show
            cmorrison Chris Morrison added a comment - Hey Tim, is that state the "We Shipped It!" button?
            Hide
            swinbank John Swinbank added a comment -

            I'm not Tim, but: yes.

            Show
            swinbank John Swinbank added a comment - I'm not Tim, but: yes.

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                cmorrison Chris Morrison
                Watchers:
                Chris Morrison, Jim Bosch, John Parejko, John Swinbank, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel