Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-560

Remove CatalogStarSelectorTask

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      Per DM-9837, CatalogStarSelector does not appear to be used anywhere in the stack currently. It therefore makes sense to delete this piece of code from the stack.  This will prevent having to update the Doxegyn to Sphinx/numpydoc as per. DM-14133

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17297 Remove CatalogStarSelector

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9837 Refactor meas_astrom/catalogStarSelector to new BaseClass

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14133 Enable Sphinx support for meas_astrom

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            cmorrison Chris Morrison [X] (Inactive) created issue -
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            We will someday need some kind of catalog-based star selector, but I don't think the API for this one has ever made sense, and that is reflected in its lack of use.  Essentially, a catalog-based star selector can't really have a proper is-a relationship with a base class that has no way to provide such a catalog in its interface.

            Show
            jbosch Jim Bosch added a comment - We will someday need some kind of catalog-based star selector, but I don't think the API for this one has ever made sense, and that is reflected in its lack of use.  Essentially, a catalog-based star selector can't really have a proper is-a relationship with a base class that has no way to provide such a catalog in its interface.
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-9837 [ DM-9837 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-14133 [ DM-14133 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Chris Morrison [X] what do you want to do with this RFC? I suggest we adopt it based on the comment from Jim Bosch.

            Show
            tjenness Tim Jenness added a comment - Chris Morrison [X] what do you want to do with this RFC? I suggest we adopt it based on the comment from Jim Bosch .
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Hey Tim,

            Thanks for reminding me. I agree and will mark this as Adopted and make a ticket to delete the task.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Hey Tim, Thanks for reminding me. I agree and will mark this as Adopted and make a ticket to delete the task.
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Link This issue is triggering DM-17297 [ DM-17297 ]
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Adopting RFC-560 removing the unused CatalogStarSelector.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Adopting RFC-560 removing the unused CatalogStarSelector.
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Chris Morrison [X] it looks like this RFC can be marked as implemented.

            Show
            tjenness Tim Jenness added a comment - Chris Morrison [X] it looks like this RFC can be marked as implemented.
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Hey Tim, is that state the "We Shipped It!" button?

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Hey Tim, is that state the "We Shipped It!" button?
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I'm not Tim, but: yes.

            Show
            swinbank John Swinbank added a comment - I'm not Tim, but: yes.
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Adopted [ 10806 ] Implemented [ 11105 ]
            gcomoretto Gabriele Comoretto [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 19591 ]

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko, John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins Builds

                  No builds found.