Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-565

Retire coadd_chisquared and clean up coadd_utils

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      The coadd_chisquared package is moribund: it's not in regular use and has not seen any substantive development work in several years. It is included in lsst_apps and lsst_distrib by way of pipe_tasks' table file, but is not used by that package.

      The coadd_utils package provides some utility code (setCoaddEdgeBits, copyGoodPixels, CoaddDataIdContainer) which is used by the coaddition routines in pipe_tasks, and a Coadd base class which is only used by coadd_chisquared.

      I propose:

      • To drop the pipe_tasks dependency on coadd_chisquared;
      • To move the coadd_chisquared repository to https://github.com/lsst-dm/legacy-coadd_chisquared;
      • To remove the Coadd class and any supporting code from coadd_utils;
      • To remove the (deprecated and unused) makeBitMask function from coadd_utils.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            +1.

            Also consider renaming coadd_utils to coadd_base or moving the code to another package. It's not much code but the only other package that comes to mind is afw/math, and afw is already so bloated I am a bit reluctant to add anything else to it. Such a change would, of course, require trivial changes to the few other packages that use it.

            Show
            rowen Russell Owen added a comment - +1. Also consider renaming coadd_utils to coadd_base or moving the code to another package. It's not much code but the only other package that comes to mind is afw/math, and afw is already so bloated I am a bit reluctant to add anything else to it. Such a change would, of course, require trivial changes to the few other packages that use it.
            Hide
            tjenness Tim Jenness added a comment -

            I am happy with doing this. We are fairly confident that no-one outside of LSST is using this code.

            Show
            tjenness Tim Jenness added a comment - I am happy with doing this. We are fairly confident that no-one outside of LSST is using this code.
            Hide
            swinbank John Swinbank added a comment -

            (Set to “board recommends” following DM-CCB sign off).

            Show
            swinbank John Swinbank added a comment - (Set to “board recommends” following DM-CCB sign off).
            Hide
            swinbank John Swinbank added a comment -

            I propose to adopt this RFC as written, rather than making further changes to coadd_utils (renaming, or merging with another package), in the interests of minimizing disruption (and because that's what the DM-CCB signed off on).

            Show
            swinbank John Swinbank added a comment - I propose to adopt this RFC as written, rather than making further changes to coadd_utils (renaming, or merging with another package), in the interests of minimizing disruption (and because that's what the DM-CCB signed off on).

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Watchers:
              John Swinbank, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  CI Builds

                  No builds found.