Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
Description
The coadd_chisquared package is moribund: it's not in regular use and has not seen any substantive development work in several years. It is included in lsst_apps and lsst_distrib by way of pipe_tasks' table file, but is not used by that package.
The coadd_utils package provides some utility code (setCoaddEdgeBits, copyGoodPixels, CoaddDataIdContainer) which is used by the coaddition routines in pipe_tasks, and a Coadd base class which is only used by coadd_chisquared.
I propose:
- To drop the pipe_tasks dependency on coadd_chisquared;
- To move the coadd_chisquared repository to https://github.com/lsst-dm/legacy-coadd_chisquared;
- To remove the Coadd class and any supporting code from coadd_utils;
- To remove the (deprecated and unused) makeBitMask function from coadd_utils.
Attachments
Issue Links
Activity
I am happy with doing this. We are fairly confident that no-one outside of LSST is using this code.
(Set to “board recommends” following DM-CCB sign off).
I propose to adopt this RFC as written, rather than making further changes to coadd_utils (renaming, or merging with another package), in the interests of minimizing disruption (and because that's what the DM-CCB signed off on).
+1.
Also consider renaming coadd_utils to coadd_base or moving the code to another package. It's not much code but the only other package that comes to mind is afw/math, and afw is already so bloated I am a bit reluctant to add anything else to it. Such a change would, of course, require trivial changes to the few other packages that use it.