Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-57

retire datarel, ap, and testing_endToEnd packages

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      this issue page

      Description

      I don't think there's anything in any of these packages that is currently in use or planned to be in use in the future (functionality previously provided by these packages will be rewritten from the ground up).

      My main goal here is to retire ap, which is a dependency of the others, so I can make modifications to afw::table (such as on DM-1766) without having to worry about breaking it. If we can find a way to drop ap without dropping the others, I'd be satisfied, but I don't currently know of any reason to keep the others around.

      Note that the deadline for this RFC is early next week, and I'd like to stick to that, as I hope to merge DM-1766 soon, whether that means I have to include a patch to ap or not.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1766 Remove in-memory support of old-version afw::table objects

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1674 Data ingest scripts cleanup

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2948 Remove explicit buildbot dependency on datarel

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2928 move old ingest scripts into and retire old packages

          • Won't Fix
          relates to

          Technical task - Created by JIRA Agile - do not edit or delete. Issue type for a technical task. DM-2772 datarel tests depend on EUPS

          • Done

          Technical task - Created by JIRA Agile - do not edit or delete. Issue type for a technical task. DM-2773 testing_endtoend tests depend on EUPS

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-275 Add daf_ingest to lsst_distrib

          • Withdrawn

            Activity

            Ascending order - Click to sort in descending order
            12 older comments
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            So, it sounds like I should:

            • Rename datarel to daf_ingest, and remove code that doesn't pertain to ingest.
            • Remove ap and testing_endToEnd from the lsst_apps lsst_distrib dependencies.

            Any objections to me doing this as a subtask issue of DM-1674? I'm happy to do this much myself, to unblock DM-1766 (and then leave the rest of DM-1674 to the DB team).

            Show
            jbosch Jim Bosch added a comment - So, it sounds like I should: Rename datarel to daf_ingest , and remove code that doesn't pertain to ingest. Remove ap and testing_endToEnd from the lsst_apps lsst_distrib dependencies. Any objections to me doing this as a subtask issue of DM-1674 ? I'm happy to do this much myself, to unblock DM-1766 (and then leave the rest of DM-1674 to the DB team).
            Hide
            Permalink
            jbecla Jacek Becla added a comment -

            Sounds good to me.

            Show
            jbecla Jacek Becla added a comment - Sounds good to me.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Resolution is to rename datarel to daf_ingest and delete everything but the current ingest scripts. Implementation issue is DM-2928.

            Show
            jbosch Jim Bosch added a comment - Resolution is to rename datarel to daf_ingest and delete everything but the current ingest scripts. Implementation issue is DM-2928 .
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            As part of cleaning up after this RFC, ap has been deprecated and now lives at https://github.com/lsst-dm/legacy-ap.

            Show
            swinbank John Swinbank added a comment - As part of cleaning up after this RFC, ap has been deprecated and now lives at https://github.com/lsst-dm/legacy-ap .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            datarel is still in lsst_distrib because of documentation build issues. The work to fix that is in DM-2948 so I think it was a bit premature to mark this RFC as implemented.

            Show
            tjenness Tim Jenness added a comment - datarel is still in lsst_distrib because of documentation build issues. The work to fix that is in DM-2948 so I think it was a bit premature to mark this RFC as implemented.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Dominique Boutigny, Jacek Becla, Jim Bosch, John Swinbank, Kian-Tat Lim, Serge Monkewitz, Tim Jenness, Yusra AlSayyad
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.