Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-603

Use scarlet v0.5 in the stack

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM, LSST
    • Labels:
      None

      Description

      The current version of scarlet (v0.5) requires a package that can calculate automatic gradients. The `autograd` was chosen as the package to calculate automatic gradients in scarlet because it is very robust and effective, developed at the HIPS group in the Harvard C.S department (now LIPS at Princeton), and also very lightweight, with only a dozen or so modules and only two dependencies: numpy and future, both of which are already included in the stack.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            RFC implemented with DM-19991

            Show
            fred3m Fred Moolekamp added a comment - RFC implemented with DM-19991
            Hide
            fred3m Fred Moolekamp added a comment -

            Unless there are no objections, I'm going to move this to adopted today and implement this on Monday.

            Show
            fred3m Fred Moolekamp added a comment - Unless there are no objections, I'm going to move this to adopted today and implement this on Monday.
            Hide
            fred3m Fred Moolekamp added a comment -

            Right, that's why we have to use the current autograd master as a 3rd party package. It was already tested during the deblender sprint in Princeton and has been in use for several months outside the stack, and within the stack for development for the past month.

            Show
            fred3m Fred Moolekamp added a comment - Right, that's why we have to use the current autograd master as a 3rd party package. It was already tested during the deblender sprint in Princeton and has been in use for several months outside the stack, and within the stack for development for the past month.
            Hide
            tjenness Tim Jenness added a comment -

            This one: https://github.com/HIPS/autograd

            I see no pypi release in two years.

            Show
            tjenness Tim Jenness added a comment - This one: https://github.com/HIPS/autograd I see no pypi release in two years.
            Hide
            fred3m Fred Moolekamp added a comment -

            Yes, autograd needs to be added as a 3rd party package. autograd is not on conda and even the latest version on PYPI does not have FFT support, which we need to do PSF matching and convolutions. Fortunately it is a very light package with no new dependencies.

            Show
            fred3m Fred Moolekamp added a comment - Yes, autograd needs to be added as a 3rd party package. autograd is not on conda and even the latest version on PYPI does not have FFT support, which we need to do PSF matching and convolutions. Fortunately it is a very light package with no new dependencies.
            Hide
            erykoff Eli Rykoff added a comment -

            So is this RFC to specifically add autograd to the stack as well? Is this through conda or does it need to be a full third-party package?

            Show
            erykoff Eli Rykoff added a comment - So is this RFC to specifically add autograd to the stack as well? Is this through conda or does it need to be a full third-party package?

              People

              • Assignee:
                fred3m Fred Moolekamp
                Reporter:
                fred3m Fred Moolekamp
                Watchers:
                Andrew Bradshaw, Eli Rykoff, Fred Moolekamp, Kian-Tat Lim, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel