Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-627

Remove obs_monocam and obs_comCam from lsst_obs

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      I would like to remove these two obs packages from lsst_obs (and therefore remove them from the lsst_distrib build). obs_comCam has been completely superseded by obs_lsst and does not work. obs_monocam was written for some LSST prototype data but my understanding is that the data are not very useful and it would be a lot of work to make the package usable (although I see an open pull request from 2 years ago by a Jason Brooks that is attempting to improve it). As part of DM-21152 I added a simple test to the package and it broke immediately because in the past few years there have been API changes that were not applied to this package. This implies that the package is not worth supporting inside LSST.

      For this RFC:

      1. Remove obs_monocam and obs_comCam from lsst_obs.
      2. Move obs_comCam to lsst-dm org and rename it legacy.

      I'm not sure if we want to leave obs_monocam around in the lsst org, or whether it should be moved to lsst-dm and renamed legacy, or moved to lsst-dm and left where it is.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment - - edited

            At CCB today we decided that we would not include a special exemption for obs packages in the developer guide. Instead we will treat them like any other package such that we support obs packages in lsst_obs and if we wish to stop supporting one we file an RFC.

            Show
            tjenness Tim Jenness added a comment - - edited At CCB today we decided that we would not include a special exemption for obs packages in the developer guide. Instead we will treat them like any other package such that we support obs packages in lsst_obs and if we wish to stop supporting one we file an RFC.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            We should move on this as devs are wasting time updating doomed packages - I've just noticed a push from Christopher Waters updating obs_monocam

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - We should move on this as devs are wasting time updating doomed packages - I've just noticed a push from Christopher Waters updating obs_monocam
            Hide
            tjenness Tim Jenness added a comment -

            Yes. I spoke to him a while back (he had done the work before this RFC).

            Show
            tjenness Tim Jenness added a comment - Yes. I spoke to him a while back (he had done the work before this RFC).
            Hide
            czw Christopher Waters added a comment -

            Sorry for not adding that note here.  I'm fine with obs_monocam going away.  However, until that happens, I needed to keep it up to date with my ticket to keep Jenkins from falling over.

            Show
            czw Christopher Waters added a comment - Sorry for not adding that note here.  I'm fine with obs_monocam going away.  However, until that happens, I needed to keep it up to date with my ticket to keep Jenkins from falling over.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Yes, exactly, hence saying we should hurry up and kill these!

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Yes, exactly, hence saying we should hurry up and kill these!

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Christopher Waters, Colin Slater, John Parejko, John Swinbank, Kian-Tat Lim, Leanne Guy, Merlin Fisher-Levine, Michelle Butler, Robert Lupton, Tim Jenness, Wil O'Mullane
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End: