Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
-
Location:This RFC
Description
I propose that we add the pytest-subtests package https://github.com/pytest-dev/pytest-subtests to our standard suite of Python packages. This allows pytest to handle unittest's subTest method correctly: running all versions even if one fails.
Without this add-on package pytest stops the test at the first failure, even if more subTest cases remain to be run. That is not a disaster, but it does mean that a test failure will not produce as much useful information as it ought to.
This seems especially apropos given Paul Price's recent work with iterator support in unit tests: https://developer.lsst.io/python/testing.html#decorators-for-iteration
Attachments
Issue Links
Activity
CCB discussed this on 2019-11-20 and have no problem with adding pytest-subtests to the conda env. We recommend deferring this until after the 19.0 release has been completed.
I have used pytest-subtests just now and it works fine for me and shows up as a single "F" in the test summary output but multiple failures reported when the tests complete.
Note that in the interim for local development pip install pytest-subtests works fine and should not cause the rest of your conda installation to go wonky.
Architecture team will add this package to the base system when a convenient time is found. This may happen during the post-19 major conda uprev.
Since this is adding to the conda environment we are flagging this RFC to CCB.