Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-67

Proposal to create repository and dependency for PSFex

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      This ticket

      Description

      PSF extractor is an external library which is used to determine the PSF in an image. I am proposing creating a new repository for this external library which will become a dependency. This functionality currently exists within the HSC pipeline, and will be ported over according to the LSST practices for external libraries.

      As part of the port, I am also proposing to create another repository called meas_extensions_psfex . This repository will contain all the necessary interfaces between the LSST stack and the external library. This repository also currently exists in the HSC software stack, and will mostly be a direct port.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I read (2) as "start over from the original astromatic source", which we don't want to do.

            We do want to move the HSC repo to LSST GitHub, while maintaining a mirror of that in HSC's git repositories (probably more for political than technical reasons).

            Show
            jbosch Jim Bosch added a comment - I read (2) as "start over from the original astromatic source", which we don't want to do. We do want to move the HSC repo to LSST GitHub, while maintaining a mirror of that in HSC's git repositories (probably more for political than technical reasons).
            Hide
            ktl Kian-Tat Lim added a comment -

            I have no problem with moving the HSC repo to LSST and mirroring it back.

            Show
            ktl Kian-Tat Lim added a comment - I have no problem with moving the HSC repo to LSST and mirroring it back.
            Hide
            jbosch Jim Bosch added a comment - - edited

            An update on the current status of the third-party dependencies on this:

            Nate Lust has written a wrapper around GSL that mimics the tiny fraction of LAPACK/BLAS that PSFEx needs. Right now we're planning to build these wrappers as a (tiny) new package, using sconsUtils to build it, and then teach PSFEx's build script to find it when it looks for its LAPACK dependency. We could also try to put those wrappers into the PSFEx package and use the existing build system there to build them, but that'll require a bit more hacking on PSFEx's build scripts than we'd like to do at this stage. And if we do it separately, we can switch the backend to Eigen if we need to (because it'd be easy to build C++ via sconsUtils, while it wouldn't necessarily be easy in PSFEx's build system).

            Show
            jbosch Jim Bosch added a comment - - edited An update on the current status of the third-party dependencies on this: Nate Lust has written a wrapper around GSL that mimics the tiny fraction of LAPACK/BLAS that PSFEx needs. Right now we're planning to build these wrappers as a (tiny) new package, using sconsUtils to build it, and then teach PSFEx's build script to find it when it looks for its LAPACK dependency. We could also try to put those wrappers into the PSFEx package and use the existing build system there to build them, but that'll require a bit more hacking on PSFEx's build scripts than we'd like to do at this stage. And if we do it separately, we can switch the backend to Eigen if we need to (because it'd be easy to build C++ via sconsUtils, while it wouldn't necessarily be easy in PSFEx's build system).
            Hide
            ktl Kian-Tat Lim added a comment -

            I guess changing PSFEx's build system is much too big a job.

            Sounds OK to me to have the small wrapper package.

            Show
            ktl Kian-Tat Lim added a comment - I guess changing PSFEx's build system is much too big a job. Sounds OK to me to have the small wrapper package.
            Hide
            nlust Nate Lust added a comment -

            I am accepting the RFC. There will be a repository for psfx and meas_extensions_psfex. The code needed for the linear algebra is going to live inside psfex as there is no need for it to be present for any other package.

            Show
            nlust Nate Lust added a comment - I am accepting the RFC. There will be a repository for psfx and meas_extensions_psfex. The code needed for the linear algebra is going to live inside psfex as there is no need for it to be present for any other package.

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Watchers:
              Jim Bosch, John Swinbank, Kian-Tat Lim, Nate Lust, Paul Price, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.