Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-685

Relax rules on moving code for small moves

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Withdrawn
    • Resolution: Done
    • Component/s: Document
    • Labels:
      None

      Description

      The dev guide, as currently worded, doesn't differentiate between moving/renaming whole packages/large pieces of code, and moving single files.

      This proposal is to specifically amend that page to only mandate that process for moving entire packages, and allow single file moves to be done freely.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Is it still the case though that the code you move would get attribution in the commit message?

            Show
            tjenness Tim Jenness added a comment - Is it still the case though that the code you move would get attribution in the commit message?
            Hide
            ktl Kian-Tat Lim added a comment -

            "Freely" can encompass a lot.

            Does this mean that there could be a single commit in the destination repo of copied and renamed code, rather than separate commits for copying and renaming? Presumably the branch and ticket descriptions would still at least vaguely refer to the transfer, but there would be no requirement that the source repo be mentioned? Would the same branch/ticket name still be used in both the source and destination packages, or could different branches be used? Could the code remain in the source package indefinitely?

            Show
            ktl Kian-Tat Lim added a comment - "Freely" can encompass a lot. Does this mean that there could be a single commit in the destination repo of copied and renamed code, rather than separate commits for copying and renaming? Presumably the branch and ticket descriptions would still at least vaguely refer to the transfer, but there would be no requirement that the source repo be mentioned? Would the same branch/ticket name still be used in both the source and destination packages, or could different branches be used? Could the code remain in the source package indefinitely?
            Hide
            krzys Krzysztof Findeisen added a comment -

            I'm all for this. The two-branches system is a nightmare to rebase if there are any concurrent changes, and I don't think it actually accomplishes anything.

            Though I do think we should still have some rules, like separate commits for moving and editing (Git/GitHub are getting better about presenting combined moves+changes coherently, but they're not all the way there yet).

            Show
            krzys Krzysztof Findeisen added a comment - I'm all for this. The two-branches system is a nightmare to rebase if there are any concurrent changes, and I don't think it actually accomplishes anything. Though I do think we should still have some rules, like separate commits for moving and editing (Git/GitHub are getting better about presenting combined moves+changes coherently, but they're not all the way there yet).

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Watchers:
              Kian-Tat Lim, Krzysztof Findeisen, Merlin Fisher-Levine, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End: