Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-689

Create new v19.0.1 release with fix for DM-24523

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Withdrawn
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      DM-24523 resolves an issue which will prevent successful installation of v19.0.0 in some circumstances. I request a v19.0.1 patch release, consisting a backport of the changes from DM-24523 to the 19.0.0 tag.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            If this is in a test doesn't it mean that it only affects people doing source installs? Binary installs will work fine. For source installs is the problem that if your user name happens to have "fr" in it the test fails? (most other workarounds would involve telling people to use a different build directory).

            Show
            tjenness Tim Jenness added a comment - If this is in a test doesn't it mean that it only affects people doing source installs? Binary installs will work fine. For source installs is the problem that if your user name happens to have "fr" in it the test fails? (most other workarounds would involve telling people to use a different build directory).
            Hide
            tjenness Tim Jenness added a comment -

            For my final comment I was trying to say that it's easier to tell people to use a different build directory than it is to tell them they have to change their user name.

            Show
            tjenness Tim Jenness added a comment - For my final comment I was trying to say that it's easier to tell people to use a different build directory than it is to tell them they have to change their user name.
            Hide
            rowen Russell Owen added a comment -

            +1 I'm all for fixing known bugs. It potentially saves a lot of time and frustration.

            Show
            rowen Russell Owen added a comment - +1 I'm all for fixing known bugs. It potentially saves a lot of time and frustration.
            Hide
            tjenness Tim Jenness added a comment -

            Would it make sense to include the other patch that people talked about including if we are going to go to the effort of a new release? I'm not entirely convinced that this edge case (supporting source builds for people who can't avoid having "fr" in their path) is enough to justify the work.

            Show
            tjenness Tim Jenness added a comment - Would it make sense to include the other patch that people talked about including if we are going to go to the effort of a new release? I'm not entirely convinced that this edge case (supporting source builds for people who can't avoid having "fr" in their path) is enough to justify the work.
            Hide
            price Paul Price added a comment -

            Could someone please explain why this was withdrawn?

            Show
            price Paul Price added a comment - Could someone please explain why this was withdrawn?
            Hide
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

            The DM-CCB has discussed the progress on this RFC in the past weeks and took the decision to withdraw it because the cost of implementation was not worth it for the changes to be included.

            The main reason is that, since the release 19.0.0 has been done, a breaking change in the build system has been introduced (conda compilers and moving 3rd party libraries into conda-forge). This change makes it very difficult to use the release tooling to issue a patch for releases prior to the change.

            This is an exceptional situation that we should be experiencing very seldom, but we cannot exclude a priori. In principle, we should be able to do patch releases on the next major 20.0.0 release and future ones, unless another breaking change in the build infrastructure and tooling is implemented.

            We are working to refactor the release tooling so that future changes will not cause this problem.

            Show
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - The DM-CCB has discussed the progress on this RFC in the past weeks and took the decision to withdraw it because the cost of implementation was not worth it for the changes to be included. The main reason is that, since the release 19.0.0 has been done, a breaking change in the build system has been introduced (conda compilers and moving 3rd party libraries into conda-forge). This change makes it very difficult to use the release tooling to issue a patch for releases prior to the change. This is an exceptional situation that we should be experiencing very seldom, but we cannot exclude a priori. In principle, we should be able to do patch releases on the next major 20.0.0 release and future ones, unless another breaking change in the build infrastructure and tooling is implemented. We are working to refactor the release tooling so that future changes will not cause this problem.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Watchers:
              Gabriele Comoretto [X] (Inactive), John Swinbank, Kian-Tat Lim, Krzysztof Findeisen, Paul Price, Russell Owen, Tim Jenness
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.