Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-693

Add alert Avro schemas and supporting Python code to lsst_distrib

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      The lsst-dm/sample-avro-alert repository holds the Avro schema definitions for alert packets, and some Python utility code (in lsst.alert.packet) for loading those definitions. DM-24324 adds alert generation to the production pipeline, so these definitions are now ready to be used in the stack.

      Before adding lsst.alert.packet to lsst_distrib, this repository should be renamed and moved to lsst/alert_packet.

      fastavro is a third-party dependency of the Python utility code, and is necessary for using the Avro schemas. It should be added to lsst_thirdparty too, I think (but am not sure - is that the right destination? I'm still learning the basics).

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Usually if a package is called "alert_packets" we expect the python import to be lsst.alert.packets so there seems to be an inconsistency in the proposed naming at the moment.

            Is there a fastavro conda-forge package?

            Show
            tjenness Tim Jenness added a comment - Usually if a package is called "alert_packets" we expect the python import to be lsst.alert.packets so there seems to be an inconsistency in the proposed naming at the moment. Is there a fastavro conda-forge package?
            Hide
            swnelson Spencer Nelson added a comment -

            Tim Jenness:

            Usually if a package is called "alert_packets" we expect the python import to be lsst.alert.packets so there seems to be an inconsistency in the proposed naming at the moment.

            Right, let's call the package alert_packet. I'll update the ticket description.

            Is there a fastavro conda-forge package?

            Yes: https://anaconda.org/conda-forge/fastavro

            Show
            swnelson Spencer Nelson added a comment - Tim Jenness : Usually if a package is called "alert_packets" we expect the python import to be lsst.alert.packets so there seems to be an inconsistency in the proposed naming at the moment. Right, let's call the package alert_packet . I'll update the ticket description. Is there a fastavro conda-forge package? Yes: https://anaconda.org/conda-forge/fastavro
            Hide
            ebellm Eric Bellm added a comment -

            I support this RFC, which is necessary for implementing alert serialization in AP.

            Show
            ebellm Eric Bellm added a comment - I support this RFC, which is necessary for implementing alert serialization in AP.
            Hide
            swinbank John Swinbank added a comment -

            Show
            swinbank John Swinbank added a comment -
            Hide
            bvan Brian Van Klaveren added a comment -

            Which version(s) of fastavro has been tested? conda-forge has 0.23.3, there's also 0.22.13 - I assume 0.23.3 would be fine. If so, I could add it to a DM-24758.

            Show
            bvan Brian Van Klaveren added a comment - Which version(s) of fastavro has been tested? conda-forge has 0.23.3, there's also 0.22.13 - I assume 0.23.3 would be fine. If so, I could add it to a DM-24758 .
            Hide
            swnelson Spencer Nelson added a comment -

            Brian Van Klaveren, I've been using 0.23.3. I think that's the right version. Thanks.

            Show
            swnelson Spencer Nelson added a comment - Brian Van Klaveren , I've been using 0.23.3. I think that's the right version. Thanks.
            Hide
            bvan Brian Van Klaveren added a comment - - edited

            I've added it - it's available with commit 4b6dfde in the tickets/DM-24758 branch. If you are are using lsstsw, you can run `bin/deploy -r tickets/DM-24758` to install the environment use envconfig to activate and test code, or supply the hash to a stack-os-matrix job in jenkins with your branch.

            Show
            bvan Brian Van Klaveren added a comment - - edited I've added it - it's available with commit 4b6dfde in the tickets/ DM-24758 branch. If you are are using lsstsw, you can run `bin/deploy -r tickets/ DM-24758 ` to install the environment use envconfig to activate and test code, or supply the hash to a stack-os-matrix job in jenkins with your branch.

              People

              Assignee:
              swnelson Spencer Nelson
              Reporter:
              swnelson Spencer Nelson
              Watchers:
              Brian Van Klaveren, Eric Bellm, John Parejko, John Swinbank, Spencer Nelson, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.