Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
Description
Unit testing calibration production is not always successful in finding issues, as the process is cumulative: products are built using previously built products. In addition, the data and processing time requirements for full testing are larger than a set of unit tests can handle.
Ticket DM-23302 will add a LATISS based ci suite to the lsst-dm github organization. This includes a top level `ci_cpp` package, `ci_cpp_gen2` and `ci_cpp_gen3` packages for the different butler/processing methods, and a `testdata_latiss_cpp` package to hold the input data.
I don't believe this needs to be regularly run, but it should be at least very highly recommended that any changes to `cp_pipe` and `ip_isr` be run through the suite prior to merging.
DM-26170 will be the implementation ticket for adding these packages, to separate the functionality review (DM-23302) from this RFC.
Attachments
Issue Links
Activity
`ci_cpp_gen2` takes 1 hour 10 minutes. `ci_cpp_gen3` takes 10 minutes, because it doesn't implement all the features yet. When those features are added, the time will not increase to the `ci_cpp_gen2` level, as the gen3 design has better reuse of processed data.
I happy for this to run more often. I don't know what the constraints of adding things for daily/weekly processing are, and wanted to set a low minimum.
Nightly is fine for a couple of hours. 10 minutes you could sneak it into lsst_ci but if you think it will become an hour there is no point doing that.
I'm going to mark this RFC as Shipped, and close DM-26170, as the packages have been migrated to the lsst organization. It does not build on Jenkins, but is not set up to run in Jenkins by default. I will resolve the Jenkins build issues on DM-26845, as it looks like all of the dependencies need updating.
I agree with the comments above; this should be run at least daily and errors flagged for prompt resolution.