Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-802

Add analysis_drp to lsst_distrib

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      analysis_drp is a gen 3 only plotting package for QA purposes. It will hopefully replace pipe_analysis in serving DM's QA plotting needs.

        Attachments

        1. colour_colour.png
          colour_colour.png
          248 kB
        2. scatter.png
          scatter.png
          125 kB
        3. skyPlot.png
          skyPlot.png
          270 kB

          Issue Links

            Activity

            Hide
            sophiereed Sophie Reed added a comment -
            Show
            sophiereed Sophie Reed added a comment - Implementation ticket:  https://jira.lsstcorp.org/browse/DM-32711
            Hide
            tjenness Tim Jenness added a comment -

            Sophie Reed is there a hold up on this RFC that is preventing it from being adopted?

            Show
            tjenness Tim Jenness added a comment - Sophie Reed is there a hold up on this RFC that is preventing it from being adopted?
            Hide
            jbosch Jim Bosch added a comment -

            Meredith's comment suggests to me that we might want an `analysis_base` class, if the drp and ap codes are going to be sharing things

            Yup, this was at least vaguely part of the plan all along - we just decided to stand up something that worked before trying to figure out which bits we might want to factor out into a more general package.  I'd like to keep that separate from this RFC, but I think it might make sense to do either while standing up a corresponding AP package or just after (with either some duplication or a AP->DRP dependency as we work through the refactoring).

            I'd be interested to hear Sophie Reed 's thoughts on whether the boundary between DRP-specific and more general stuff has ended up pretty clear already in the current version, though.

            Show
            jbosch Jim Bosch added a comment - Meredith's comment suggests to me that we might want an `analysis_base` class, if the drp and ap codes are going to be sharing things Yup, this was at least vaguely part of the plan all along - we just decided to stand up something that worked before trying to figure out which bits we might want to factor out into a more general package.  I'd like to keep that separate from this RFC, but I think it might make sense to do either while standing up a corresponding AP package or just after (with either some duplication or a AP->DRP dependency as we work through the refactoring). I'd be interested to hear Sophie Reed 's thoughts on whether the boundary between DRP-specific and more general stuff has ended up pretty clear already in the current version, though.
            Hide
            Parejkoj John Parejko added a comment -

            Meredith's comment suggests to me that we might want an `analysis_base` class, if the drp and ap codes are going to be sharing things (I don't know if they will, but it's worth considering).

            Show
            Parejkoj John Parejko added a comment - Meredith's comment suggests to me that we might want an `analysis_base` class, if the drp and ap codes are going to be sharing things (I don't know if they will, but it's worth considering).
            Hide
            mrawls Meredith Rawls added a comment -

            Yay! Please ensure the package has some docs and tests, and no extraneous directories or table file entries, as K-T and John point out. Looking forward to borrowing lots of what you've done for analysis_ap, so the more good life choices you can make here, the happier we will all be!

            Show
            mrawls Meredith Rawls added a comment - Yay! Please ensure the package has some docs and tests, and no extraneous directories or table file entries, as K-T and John point out. Looking forward to borrowing lots of what you've done for analysis_ap, so the more good life choices you can make here, the happier we will all be!

              People

              Assignee:
              sophiereed Sophie Reed
              Reporter:
              sophiereed Sophie Reed
              Watchers:
              Colin Slater, Jim Bosch, John Parejko, Kian-Tat Lim, Lee Kelvin, Meredith Rawls, Sophie Reed, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.