Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-832

Add summit_utils and summit_extras to lsst_sitcom

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      Add rapid_analysis to lsst_distrib (or other metapackage)

      A SITCOM package called rapid_analysis exists, which provides many utility functions for observers and commissioning scientists on the summit. Currently it is AuxTel-specific, and this is very much by design† - this is not intended to provide tools for other observatories. Furthermore, while it mostly plays by the DM rules/coding standards, it does not always, again out of necessity - the package is for working live and performing non-pipeline-types of analysis, so a certain amount of pragmatism is necessary, though it is kept to a minimum wherever reasonably possible.

      Given that it is required by observers and commissioning scientists (not to mention a growing number of users) it is unfortunate that it both does not currently benefit from our CI system††, and also requires manual installation on the summit by anyone who wishes to use it, despite it containing code that observing depends on.

      This RFC is to discuss adding it to our distribution. I am agnostic about whether it should go into lsst_distrib, or whether a new metapackage, which would be a superset of lsst_distrib, be created to house it (and potentially other commissioning tools). Personally, I'd lean towards not (yet) creating a new metapackage, and instead moving some of the more "core" packages "up" to lsst_apps†††, thereby making lsst_distrib closer to how it was originally intended to function, and allowing this in (not to mention that this is just less friction, and deployments don't then have to name a new metapackage as their target), but if people have strong feelings on that, they can be discussed here.

      The intention is to add the package only after DM-31522 has had its lengthy review comments addressed and is merged.

      †Whether it expands to also serve ComCam and LSSTCam in the future, or whether it gets renamed to something AuxTel-specific, or whether it's refactored to rapid_analysis_base etc, is, I believe, beyond the scope of this RFC, though surely those fill follow in the coming months.

      †† Though I'll be the first to admit it could use some more tests.

      ††† Not as part of this RFC, I just know this is something that Kian-Tat Lim has been thinking about, and it seemed relevant to mention that this is already being considered.

        Attachments

          Issue Links

            Activity

            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            DM-31522 is a massive overhaul of this code, and will largely bring it up to spec. Further updates are ticketed in DM-34238 and DM-34239, and final styles/standards can only be adhered to once SITCOMTN-033 has been written.

            I therefore propose adding this package once DM-31522 has merged, and the other tickets/updates will follow as soon as they can.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - DM-31522 is a massive overhaul of this code, and will largely bring it up to spec. Further updates are ticketed in DM-34238 and DM-34239 , and final styles/standards can only be adhered to once SITCOMTN-033 has been written. I therefore propose adding this package once DM-31522 has merged, and the other tickets/updates will follow as soon as they can.
            Hide
            tjenness Tim Jenness added a comment -

            Merlin Fisher-Levine I think this means you can adopt the RFC and add a triggering ticket for adding it to lsst_distrib.

            Show
            tjenness Tim Jenness added a comment - Merlin Fisher-Levine I think this means you can adopt the RFC and add a triggering ticket for adding it to lsst_distrib.
            Hide
            tjenness Tim Jenness added a comment -

            Merlin Fisher-Levine do you intend to adopt this RFC? Please add a triggering ticket.

            Show
            tjenness Tim Jenness added a comment - Merlin Fisher-Levine do you intend to adopt this RFC? Please add a triggering ticket.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I do. I am curently waiting to split the package before adding (I will add them both, but want to make the split before doing the add to save the changes in the deployed version, that feels like the right way around to me).

            I will make the ticket now though, no need to wait on that part.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I do. I am curently waiting to split the package before adding (I will add them both, but want to make the split before doing the add to save the changes in the deployed version, that feels like the right way around to me). I will make the ticket now though, no need to wait on that part.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Adopted, and implementation ticket filed.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Adopted, and implementation ticket filed.

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Watchers:
              Adam Thornton, Colin Slater, John Parejko, Kian-Tat Lim, Merlin Fisher-Levine, Patrick Ingraham, Tiago Ribeiro, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.