Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:
Description
ScaleVarianceTask is used in image differencing, and the refactored ImageDifferenceTask (DM-33001) is expected to be in ip_diffim instead of pipe_tasks. The current ScaleVarianceTask lives in pipe_tasks, so it would create a circular dependency to import it in ip_diffim. Instead, it should be moved to meas_algorithms, where it would fit in with similar measurement algorithms like SubtractBackgroundTask. After this RFC is adopted, all imports in the DM stack will be changed to lsst.meas.algorithms.ScaleVarianceTask, and a deprecation warning will be added to lsst.pipe.tasks.ScaleVarianceTask, with removal after v24.
Attachments
Issue Links
Activity
I have a task in a ticket branch (yet to make a PR) hat computes the noise correlation and should live wherever ScaleVarianceTask lives logically speaking. However, putting it in pipe_tasks didn't make sense either since no pipeline is actively using it yet. meas_algorithms seems like a good place to move these to
John Parejko The current implementation was the request of the reviewer. All of our imports have been updated to use the new code in meas_algorithms, and anyone using the old code should get a deprecation warning.
Arun Kannawadi I think meas_algorithms makes much more sense as the location for code that computes noise correlations, than pipe_tasks.
Has this RFC been implemented? The triggered ticket has been marked done.
I'd assume that lsst.pipe.tasks.ScaleVarianceTask would just become an import and _all_=[] of the meas_algorithms Task+Config, with nothing else in the file?
Otherwise, this sounds like a good idea.