Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-850

Deprecate Psf::computeBBox()

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Adopted
    • Resolution: Unresolved
    • Component/s: DM
    • Labels:
      None

      Description

      For historical reasons, the afw::Psf class has 3 methods for computing BBoxes:

      • Psf::computeBBox(...)
      • Psf::computeImageBBox(...)
      • Psf::computeKernelBBox(...)

      Psf::computeBBox(...) is exactly equal to Psf::computeKernelBBox(...) and is thus redundant.

      This RFC proposes to deprecate Psf::computeBBox(...) and leave only the 2 more explicit bbox methods.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment - - edited

            For some additional context (and perhaps an extension to this proposal):

            • computeBBox and computeKernelBBox are equivalent to computeKernelImage().getBBox()
            • computeImageBBox is equivalent to computeImage().getBBox().
            • computeBBox is a nonvirtual method that delegates to doComputeBBox (allowing the base class to cache).
            • computeImageBBox is a nonvirtual method that delegates to doComputeImagBBox (allowing the base class to cache).

            I think that means we should at least deprecate doComputeBBox as well, in favor of (adding) doComputeKernelBBox.

            We could also consider renaming (with deprecation, of course):

            • computeKernelBBox -> computeKernelImageBBox
            • doComputeKernelBBox -> doComputeKernelImageBBox
              to better match the actual method they correspond to: computeKernelImage (not computeKernel).

            Other than that, strong from me (Josh created this RFC as a direct result of my confusion about what computeBBox did).

            Show
            jbosch Jim Bosch added a comment - - edited For some additional context (and perhaps an extension to this proposal): computeBBox and computeKernelBBox are equivalent to computeKernelImage().getBBox() computeImageBBox is equivalent to computeImage().getBBox() . computeBBox is a nonvirtual method that delegates to doComputeBBox (allowing the base class to cache). computeImageBBox is a nonvirtual method that delegates to doComputeImagBBox (allowing the base class to cache). I think that means we should at least deprecate doComputeBBox as well, in favor of (adding) doComputeKernelBBox . We could also consider renaming (with deprecation, of course): computeKernelBBox -> computeKernelImageBBox doComputeKernelBBox -> doComputeKernelImageBBox to better match the actual method they correspond to: computeKernelImage (not computeKernel ). Other than that, strong from me (Josh created this RFC as a direct result of my confusion about what computeBBox did).
            Hide
            jbosch Jim Bosch added a comment -

            Joshua Meyers, this is ready to be adopted whenever you have the time to write an implementation ticket for it.

            Show
            jbosch Jim Bosch added a comment - Joshua Meyers , this is ready to be adopted whenever you have the time to write an implementation ticket for it.
            Hide
            tjenness Tim Jenness added a comment -

            Joshua Meyers are you still intending to adopt this RFC or withdraw it?

            Show
            tjenness Tim Jenness added a comment - Joshua Meyers are you still intending to adopt this RFC or withdraw it?
            Hide
            tjenness Tim Jenness added a comment -

            Joshua Meyers please add a triggering ticket and adopt this RFC or else withdraw it if you've changed your mind.

            Show
            tjenness Tim Jenness added a comment - Joshua Meyers please add a triggering ticket and adopt this RFC or else withdraw it if you've changed your mind.
            Hide
            jmeyers314 Joshua Meyers added a comment -

            Adopting all of Jim's suggestions above.

            Show
            jmeyers314 Joshua Meyers added a comment - Adopting all of Jim's suggestions above.

              People

              Assignee:
              jmeyers314 Joshua Meyers
              Reporter:
              jmeyers314 Joshua Meyers
              Watchers:
              Arun Kannawadi, Jim Bosch, John Parejko, Joshua Meyers, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Planned End:

                  Jenkins

                  No builds found.