Details
-
Type:
RFC
-
Status: Adopted
-
Resolution: Unresolved
-
Component/s: DM
-
Labels:None
Description
For historical reasons, the afw::Psf class has 3 methods for computing BBoxes:
- Psf::computeBBox(...)
- Psf::computeImageBBox(...)
- Psf::computeKernelBBox(...)
Psf::computeBBox(...) is exactly equal to Psf::computeKernelBBox(...) and is thus redundant.
This RFC proposes to deprecate Psf::computeBBox(...) and leave only the 2 more explicit bbox methods.
Attachments
Issue Links
- is triggering
-
DM-36834 Deprecate Psf::computeBBox()
- To Do
- mentioned in
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
For some additional context (and perhaps an extension to this proposal):
I think that means we should at least deprecate doComputeBBox as well, in favor of (adding) doComputeKernelBBox.
We could also consider renaming (with deprecation, of course):
to better match the actual method they correspond to: computeKernelImage (not computeKernel).
Other than that, strong
from me (Josh created this RFC as a direct result of my confusion about what computeBBox did).