Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-851

Remove support for version 0 reference catalogs

    XMLWordPrintable

Details

    Description

      We added version 1 reference catalogs in Spring 2019 (DM-17029), with flux fields having explicit units of nJy. Version 0 (aka unversioned files) had fluxes either in Jy or without units but assumed to be Jy. We have issued log warnings about v0 refcats that included information about how to convert them since DM-17029, so anyone trying to use them has been warned that they are old for a while. The log message did not explicitly say that format was deprecated.

      I propose we end support for version 0 refcats, switching to raising an exception if the refcat loader encounters v0 files. This will remove a bunch of code from meas_algorithms and simplify the refloader a bit. I'd argue that we don't need a deprecation period for this, given that the "old style units" log warnings were in place since 2019, and there hasn't been code to generate v0 refcats since that time, but we could also change the v0 warnings to include a deprecation note if required.

      I believe all our supported v0 refcats have already been converted to v1 (compare the v0 and v1 subdirectories of /datasets/refcats/html on lsst-devl), and all of our well-documented refcat generation/conversion code was written after the above date, so it's pretty likely no user-generated v0 refcats exist in the wild.

      erykoff reminded me of this code while I was reviewing DM-34484. I'm not positive that our gen3 refloader actually supports v0 conversion currently, but I think it should.

      Attachments

        Issue Links

          Activity

            erykoff Eli Rykoff added a comment -

            This is fine to deprecate/remove, we've had the notice for a long time and the only place we actually have v0 catalogs in use (that I know of) are in the the test catalogs (in meas_algorithms, meas_astrom, and pipe_tasks at least. Wouldn't be surprised if obs_decam does as well).

            However, I want to point out that the v0 refcats work perfectly fine with gen3, and tests to this effect are part of DM-34484, https://github.com/lsst/meas_algorithms/pull/278/commits/396e5c5b9cc1b64c741852b766ac33ca29f952a4

            erykoff Eli Rykoff added a comment - This is fine to deprecate/remove, we've had the notice for a long time and the only place we actually have v0 catalogs in use (that I know of) are in the the test catalogs (in meas_algorithms , meas_astrom , and pipe_tasks at least. Wouldn't be surprised if obs_decam does as well). However, I want to point out that the v0 refcats work perfectly fine with gen3, and tests to this effect are part of DM-34484 , https://github.com/lsst/meas_algorithms/pull/278/commits/396e5c5b9cc1b64c741852b766ac33ca29f952a4
            Parejkoj John Parejko added a comment -

            DM-34792 and DM-34793 are the implementation tickets.

            Parejkoj John Parejko added a comment - DM-34792 and DM-34793 are the implementation tickets.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Eli Rykoff, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                Jenkins

                  No builds found.