Details
-
Type:
RFC
-
Status: Implemented
-
Resolution: Done
-
Component/s: DM
-
Labels:None
Description
There is currently code in ip_isr that allows an amplifier to be split into two segments for the purposes of overscan correction. This was originally added for DECam, which has amplifiers that show a bias jump, where the overscan level is discontinuous. When using a simple correction method (full overscan median as an example), ignoring this jump results in a measurement that is bad everywhere.
However, I believe that obs_decam is now using the MEDIAN_PER_ROW algorithm universally, which solves the problem naturally, while also better fitting smaller features along the y-axis. If this code isn't expected to be used, it would help simplify the overscan refactor (DM-33429) greatly.
Attachments
Issue Links
Activity
This certainly sounds reasonable, though I'm not immediately sure how it would work with DECam crosstalk correction, which is a per-amp operation. I guess crosstalk isn't a per-HALF-amp operation, so if Christopher Waters and Lee Kelvin are confident this is a non-issue, consider me equally happy with this proposal to simplify our codebase.
This removal will happen as part of DM-33429.
Christopher Waters I'm confused by this RFC. It is still being proposed but the triggered ticket has been completed? Did you forget to hit the "Adopted" and "Implemented" buttons?
I forgot to clear this RFC before DM-33429 finished.
I think this makes sense to me, and I certainly have no objections to removing this functionality from a DECam perspective. Strong +1.
Edit: DECam config switch to MEDIAN_PER_ROW occurred in DM-30651.